Dark mode fix#483
Open
shreya8040 wants to merge 3859 commits into
Open
Conversation
Fetch future slots when changing months See merge request web/clients!23769
[DRVWEB-5169] Cleanup shared with me part 2 See merge request web/clients!23642
[IDTEAM-5385] Stabilize connectivity state transitions under concurrent requests See merge request web/clients!23874
[IDTEAM-4634] Hide share roles actions on a group sharing you are manager See merge request web/clients!23897
Patch lodash to 4.18.0 See merge request web/clients!23894
Sheets: Breaking change versioning See merge request web/clients!23543
Fix: wait for paymentsMethods event See merge request web/clients!23846
Add meet logo to storybooks See merge request web/clients!23710
fixed go unlimited offer See merge request web/clients!23902
[IDTEAM-4634] stop propagation group click and fix actions sharing members See merge request web/clients!23908
Improve error management in desktop unlock and break auto unlock loop See merge request web/clients!23879
Allow host remove raised hand See merge request web/clients!23837
Small fixes sharing modal See merge request web/clients!23920
Don't cleanup recording file in download function + logs See merge request web/clients!23921
Adding free Mail signup variants for experiment See merge request web/clients!23843
DRVWEB-5324: Handle gracefully abort errors in invitation loader See merge request web/clients!24016
Preapprove @ proton and @ protontech npm packages in yarnrc See merge request web/clients!24027
… / SubUserEditModal
…o 'main' AdminRole: Show "Roles and permissions" tab inside SubUserCreateModal / SubUserEditModal See merge request web/clients!23768
Make the zoom feature flag a kill switch See merge request web/clients!23892
Improve condition to show upsell icon See merge request web/clients!24002
…o 'main' Unauthed reset password flow with state machine See merge request web/clients!23627
[BOOK-401] Removed busy slots from Lumo, Meet and VPN Pass bundle See merge request web/clients!24020
Lumo guest sidebar bug fix See merge request web/clients!24033
…s' into 'main' AdminRoles: fetch user roles and permissions on app load See merge request web/clients!23957
Fallback to main currency in the bookings upsell See merge request web/clients!24035
mmso
force-pushed
the
main
branch
5 times, most recently
from
115579e to
b6fd253
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Issue #484
Hi!
I'm Shreya, a CS student who's looking to contribute to open source projects. I'm a beginner, but I like to tinker around. I noticed the composer editor stays white in dark mode which felt like a hiccup in UX, so I decided to dig into it. My skillset also lies in design and i thought this was a UI bug that was making the UX a bit annoying.
I'll be honest - it took me a while to figure out what was going on. I started by searching for the editor styles, found the hardcoded 'background: white' in RoosterEditorIframe.raw.scss, and thought that was the fix. But changing it didn't work, which sent me down a rabbit hole.
I used Claude to help me what was going wrong and tried to fix it:
The composer loads in an iframe that's isolated from the parent page, so CSS variables from the theme don't just pass through automatically. After tracing through
useInitRooster.tsanduseSyncIframeStyles, I found thatproperties.tsonly syncs two CSS variables into the iframe. Adding--background-normto that list, along with changing the hardcodedwhitein the SCSS, seemed like the right fix.I can't fully run the app locally to verify it end to end, so I'd really appreciate your review. If I've missed something or approached this wrong, I'm happy to learn and fix it!
Thank you,
Shreya